8000 fix(skeleton): resolve support for kustomizations in isolation by brandtkeller · Pull Request #3669 · zarf-dev/zarf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(skeleton): resolve support for kustomizations in isolation #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

fix(skeleton): resolve support for kustomizations in isolation #3669

merged 2 commits into from
Apr 14, 2025

Conversation

brandtkeller
Copy link
Member

Description

Attempting to create a component using manifests.kustomizations without any manifests.files will fail because it silently relies on the manifests.files loop to create the parent directory manifests which kustomize.Build() expects to exist in order to write the file.

Updated the create_test.go to include a component which has kustomizations in isolation in order to detect this going forward.

Related Issue

Fixes #3667

Checklist before merging

@brandtkeller
fix(skeleton): resolve support for kustomizations in isolation
1f032c6 
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller brandtkeller self-assigned this Apr 14, 2025
@brandtkeller brandtkeller requested review from a team as code owners April 14, 2025 18:13
@netlify Netlify
Copy link
netlify bot commented Apr 14, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 4f73ce6
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67fd509b3077a80008d11a77

@codecov Codecov
Copy link
codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/create.go 50.00% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/create.go 42.52% <50.00%> (+0.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AustinAbro321
AustinAbro321 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor
@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandtkeller brandtkeller added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit f961eab Apr 14, 2025
26 checks passed
@brandtkeller brandtkeller deleted the 3667_kustomize_fix branch April 14, 2025 20:00
nevinaragam pushed a commit to nevinaragam/zarf that referenced this pull request May 20, 2025
@brandtkeller @nevinaragam
fix(skeleton): resolve support for kustomizations in isolation (zarf-…
5083090 
…dev#3669)

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
@renovate renovate bot mentioned this pull request Jun 6, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

Assignees

@brandtkeller brandtkeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inability to publish skeleton with kustomizations
2 participants
@brandtkeller @AustinAbro321
0