feat: use websockets for port forwards #3717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
soltysh
reviewed
Apr 22, 2025
src/pkg/cluster/tunnel.go
Outdated
| return nil, err | ||
| } | ||
| dialer := spdy.NewDialer(upgrader, &http.Client{Transport: transport}, method, url) | ||
| if !cmdutil.PortForwardWebsockets.IsDisabled() { |
There was a problem hiding this comment.
I'd drop this if, since you always want to have that full fallback mechanism enabled. At least for quite a few future releases until k8s decides entirely to drop that.
There was a problem hiding this comment.
Yeah I wasn't sure if there was some niche use case where a user would still want to force the old port forwarder, assuming not I'll go ahead and remove this
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
nevinaragam
pushed a commit
to nevinaragam/zarf
that referenced
this pull request
May 20, 2025
Signed-off-by: Austin Abro <AustinAbro321@gmail.com> Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the tunnel package to use the Kubernetes portforward websocket feature. This should resolve long standing issues in the community that makes Zarf incompatible with tools like aws ssm as the current port forward method does not work well with proxies or gateways.
Related Issue
Fixes #3715
Checklist before merging