8000 fix: set default user for git and registry state during `zarf package deploy` by AustinAbro321 · Pull Request #3754 · zarf-dev/zarf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: set default user for git and registry state during zarf package deploy #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

fix: set default user for git and registry state during zarf package deploy #3754

merged 1 commit into from
May 1, 2025

Conversation

AustinAbro321
Copy link
Contributor

Description

There is a bug right now when a user runs zarf package deploy <init-package> it won't set the default push user or git repository. I believe this was introduced when cmd was refactored to not use init()s at startup. The init() seemed to be changing state for zarf init, but this behavior was also required by zarf package deploy. Regardless, it makes more sense for these default functions to not know what Zarf sets to defaults at the cmd level.

Checklist before merging

@AustinAbro321
set default user
d324074 
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners May 1, 2025 15:30
@netlify Netlify
Copy link
netlify bot commented May 1, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit d324074
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/681393ac482499000836ec55

@AustinAbro321 AustinAbro321 changed the title fix: set default user for git and registry during zarf package deploy fix: set default user for git and registry state during zarf package deploy May 1, 2025
@codecov Codecov
Copy link
codecov bot commented May 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/types/k8s.go 0.00% 6 Missing ⚠️
Files with missing lines Coverage Δ
src/types/k8s.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

brandtkeller
brandtkeller approved these changes May 1, 2025
View reviewed changes
Copy link
Member
@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Establishing defaults - aligns with the current functionality - LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue May 1, 2025
Merged via the queue into main with commit 90460ae May 1, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the set-default-push-user branch May 1, 2025 16:19
nevinaragam pushed a commit to nevinaragam/zarf that referenced this pull request May 20, 2025
@AustinAbro321 @nevinaragam
fix: set default user for git and registry state during `zarf package…
b60cf56 
… deploy` (zarf-dev#3754)

Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtkeller brandtkeller brandtkeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AustinAbro321 @brandtkeller
0