8000 Enhanced image upload by denniswittich · Pull Request #58 · zauberzeug/rosys · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enhanced image upload #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Enhanced image upload #58

merged 7 commits into from
Dec 11, 2023

Conversation

denniswittich
Copy link
Contributor

This PR allows to provide detections to the upload function of the 'Hardware Detector'. The detections are modified to match the format of the detector node. With this PR it is also possible to provide a list of tags which are forwarded to the detector node. The default behavior is not changed.

@denniswittich denniswittich marked this pull request as ready for review December 7, 2023 15:49
Copy link
Contributor
@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
Now I understand the trouble of converting box coordinates to integers. But I think it's a reasonable solution for now.

@rodja rodja added this to the 0.9.6 milestone Dec 8, 2023
@rodja rodja added the enhancement New feature or request label Dec 8, 2023
@falkoschindler falkoschindler merged commit 80c67c9 into main Dec 11, 2023
@falkoschindler falkoschindler deleted the enhanced-image-upload branch December 11, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0