8000 Allow inverting e-stops and bumpers by Johannes-Thiel · Pull Request #281 · zauberzeug/rosys · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow inverting e-stops and bumpers #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2025
Merged

Allow inverting e-stops and bumpers #281

merged 5 commits into from
May 6, 2025

Conversation

Johannes-Thiel
Copy link
Contributor
@Johannes-Thiel Johannes-Thiel commented Apr 28, 2025 •
edited by falkoschindler
Loading

The bumper and estops still use the level of the Inputs. With the introduction of the active property to Lizard in zauberzeug/lizard#38 we can make the code more readable and understandable. This also allows us to invert the inputs for specific robot configurations.
With this change we will need to reconfigure our robots to use active instead of level. This is a breaking change.

@Johannes-Thiel Johannes-Thiel added this to the 0.24.0 milestone Apr 28, 2025
@Johannes-Thiel Johannes-Thiel mentioned this pull request Apr 28, 2025
Merged
2 tasks
falkoschindler
falkoschindler requested changes Apr 28, 2025
View reviewed changes
Copy link
Contributor
@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some round brackets that should be removed
as well as two member variables that could be removed...

Johannes-Thiel and others added 2 commits April 29, 2025 08:29
@Johannes-Thiel @falkoschindler
Update rosys/hardware/bumper.py
80bb7ed 
Co-authored-by: Falko Schindler <falko@zauberzeug.com>
@Johannes-Thiel @falkoschindler
Update rosys/hardware/estop.py
d27c137 
Co-authored-by: Falko Schindler <falko@zauberzeug.com>
@falkoschindler falkoschindler merged commit 625dabb into main May 6, 2025
5 checks passed
@falkoschindler falkoschindler deleted the estop-active branch May 6, 2025 14:01
@falkoschindler falkoschindler added the breaking change Can break existing user code label May 15, 2025
@falkoschindler falkoschindler changed the title Estop and bumper use active Allow inverting e-stops and bumpers May 15, 2025
@falkoschindler falkoschindler added the enhancement New feature or request label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkoschindler falkoschindler falkoschindler approved these changes

Assignees
No one assigned
Labels
breaking change Can break existing user code enhancement New feature or request
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Johannes-Thiel @falkoschindler
0