Add a configuration for garbage_collection_mbyte_limit #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
falkoschindler
approved these changes
Jun 4, 2025
pascalzauberzeug
added a commit
to zauberzeug/field_friend
that referenced
this pull request
Jun 11, 2025
### Motivation When using the normal rosys garbage collection all functions will be stopped each minute. To prevent this we are calling the garbage collection manually, before enabling the implement when starting a new row and after the automation is finished. If no atomation is running we are starting the garbage collection every 5 minutes. ### Implementation We choose to use the garbage collection in the `field_navigation.py` at this point, because the robot is standing still while the implement will be enabled. For this reason a second of additional waiting time is okay. ### Progress - [x] I chose a meaningful title that completes the sentence: "If applied, this PR will..." - [x] I chose meaningful labels (if GitHub allows me to so). - [x] The implementation is complete. - [x] Tests with a real hardware have been successful (or are not necessary). - [x] Pytests have been added (or are not necessary). - [x] Documentation has been added (or is not necessary). - [x] Wait for zauberzeug/rosys#300 - [x] Also wait for zauberzeug/rosys#302 edit: the commit message "update to RoSys 0.25.1" is not correct, it is an update to 0.25.0 --------- Co-authored-by: Pascal Schade <pascal@zauberzeug.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In our project we have a limited amount of Memory. Due to the limit of
300 mbthe collection is run every minute. This will stop all processing. To fix this issue we want to start thegarbage_collectionin times where our system is not doing anything. For this we introduced this feature to set thegarbage_collection_mbyte_limitto0. This is also relevant for systems with smaller memory, to set the limit to the apropriate threshold.Implementation
To make it confiurable in time, we introduce the value
garbage_collection_mbyte_limitin theconfig.py.Progress