8000 FeaturePanel: Add operator dropdown and hiding editor tags by whubsch · Pull Request #161 · zbycz/osmapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FeaturePanel: Add operator dropdown and hiding editor tags #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2023
Merged

FeaturePanel: Add operator dropdown and hiding editor tags #161

merged 4 commits into from
Jun 20, 2023

Conversation

whubsch
Copy link
Contributor
@whubsch whubsch commented Jun 16, 2023

Hi, just poking around, I noticed that operator tags are not collapsed like brand and network tags were. I also added a filter to hide tags in the FeaturePanel that are primarily for OSM editors: source, check_date, fixme, comment, and note. Those tags are still viewable and available to edit in the edit window.

@vercel
Copy link
vercel bot commented Jun 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview ✅ 1 resolved Jun 20, 2023 6:14am

@Flohhhhh Flohhhhh changed the title Adding operator dropdown and hiding editor tags FeaturePanel: Add operator dropdown and hiding editor tags Jun 16, 2023
@Flohhhhh
Copy link
Contributor
Flohhhhh commented Jun 16, 2023 •
edited
Loading

Nice change!

Unfortunately, reference to #131 this may not be appropriate to pull at the moment.

It appears the TagsTable.tsx file would no longer be needed and the tag structure would change. Hopefully this change would be included in the iD exploration, otherwise @zbycz can address this.

@Flohhhhh Flohhhhh added the enhancement Minor enhancement label Jun 16, 2023
@zbycz
Copy link
Owner
zbycz commented Jun 17, 2023

Hi @whubsch, thanks for the contribution. I will be glad to merge the collapsing.

Regarding the hidden tags, i very much prefer to show the user all information from OSM. All these tags are our gold, so i would prefer not hiding any. Even for end-user browsing the map, seeing fixme could inspire an edit. Seeing source could highlight the fact, that we take attributions seriously. I am open to discussion here :)

And as @Flohhhhh mentioned, this TagsTable interface will be completely replaced for iD editor driven one, see https://osmapp-git-tagging-zbycz.vercel.app/node/2563931218
I think TagsTable will remain as some advanced mode for some time.

@whubsch
Copy link
Contributor Author
whubsch commented Jun 18, 2023

Ok, no worries, I didn't realize the tag table is getting removed. I do personally think it is worth hiding the more editor-focused tags if the goal is to make a general purpose map application. There are a lot of OSM renderers for editors, but not too many for non-editors, so I see that as a nice lane this application could fill.

I'm intrigued by this project so I'll look around with what else I can help with, although I don't have much experience with Javascript.

@Flohhhhh Flohhhhh closed this Jun 18, 2023
@Flohhhhh Flohhhhh reopened this Jun 18, 2023
zbycz and others added 2 commits June 19, 2023 20:20
@zbycz @whubsch
tagging: add iD Tagging scheme to advanced mode 🎉 (zbycz#131)
5a492a7 
* iD Tagging scheme exploration

* fix build

* fix build2

* show only unique fields

* add typescript types

* y lintfix

* find Field for rest of tags

* move schema to Feature + add UI

* translate values in semiCombo

* titles

* hack address:* in

* remove tags which are already covered by Preset name

* experiment - clear sessionstorage

* typeCombo is usually cleared by preset.tags

* We need typeCombo after all, eg node/7002486683

* move units from label to value

* finalize first prototype

* allow language switching

* fix buildAddress a little

* extract PoiDescription.tsx

* extract field helpers to fields.ts

* refactoring restKeys->keysTodo, added publishDbgObject(), added test

* fix access key - covers multiple tags

* Use `@openstreetmap/id-tagging-schema` pkg

Committed in-flight 5J814 :)

* fix keysTodo (never commit 30k ft above ground)

* y lintfix

* fix [object object] in `subject:wikidata`

* update osmApi.test.ts

* hide under advanced mode

* add Details above TagsTable
@whu 8000 bsch
Removing hiding tags filter
44fb928
zbycz
zbycz approved these changes Jun 20, 2023
View reviewed changes
Copy link
Owner
@zbycz zbycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the cherrypicked commit, because github somehow messed up the "Files changed". Even though it is aleady in master branch.

@zbycz zbycz merged commit 7e3d3bf into zbycz:master Jun 20, 2023
@zbycz
Copy link
Owner
zbycz commented Jun 20, 2023

Thanks for your first contribution. It should be deployed in a minute. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbycz zbycz zbycz approved these changes

Assignees
No one assigned
Labels
enhancement Minor enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whubsch @Flohhhhh @zbycz
0