Fix adding CanvasPattern #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code was going into an infinite loop It's also setting `patternUnits` to `userSpaceOnUse` in order to get the same behaviour as canvas patterns
|
Dear @zenozeng I took the liberty of writing this PR to fix an infinite loop when Please have a look. Thanks |
|
@x4d3 |
|
@zenozeng Good question, I took the image from here: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/createPattern so I assumed it was free to use. To be fair any image would do. |
|
@x4d3 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code was going into an infinite loop.
It's also setting
patternUnitstouserSpaceOnUsein order to get the same behaviour as canvas patterns