fixes a vulkan validation error , VUID-vkDestroyInstance-instance-00629 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
somehow it still doesn't work |
|
The code was recently switched to require Vulkan 1.4; I’m not sure if Intel has released compatible drivers yet. |
|
I'll merge this fix since this is good to apply anyway; if you want to run this using your existing drivers, you can sync to tag |
|
yeah i tried and i got this (gdb) run list
Starting program: /home/lka/practice/mygames/niagara-vulkan1.3/niagara list
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
Enabled Vulkan validation layers (sync validation disabled)
[New Thread 0x7ffff2abe6c0 (LWP 19293)]
GPU0: Intel(R) UHD Graphics (TGL GT2)
Selected GPU Intel(R) UHD Graphics (TGL GT2)
[New Thread 0x7ffff6eb06c0 (LWP 19294)]
ERROR: Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08740 ] | MessageID = 0x6e224e9 | vkCreateShaderModule(): SPIR-V Capability MeshShadingEXT was declared, but one of the following requirements is required (VK_EXT_mesh_shader).
The Vulkan spec states: If pCode is a pointer to SPIR-V code, and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, one of the corresponding requirements must be satisfied (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08740)
niagara: /home/lka/practice/mygames/niagara-vulkan1.3/src/device.cpp:135: VkBool32 debugReportCallback(VkDebugReportFlagsEXT, VkDebugReportObjectTypeEXT, uint64_t, size_t, int32_t, const char*, const char*, void*): Assertion `!"Validation error encountered!"' failed.
Thread 1 "niagara" received signal SIGABRT, Aborted.
__pthread_kill_implementation (threadid=<optimized out>,
signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
44 return INTERNAL_SYSCALL_ERROR_P (ret) ? INTERNAL_SYSCALL_ERRNO (ret) : 0; |
|
Yeah this is part of why there was a switch to Vulkan 1.4; this specific error is benign (you can just disable validation and it's going to work just fine in practice I believe). This was introduced by the shader loading rework, the last commit before it is probably cd13034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
well i got the error so i fixed it ,