This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Complete v3 support #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] ZF3 support Conflicts: composer.json
- Use PHP 5.6 or 7.0 - Use zf-api-problem `^1.2.1` - Use zf-hal `^1.4` - Move `Module` class under `src/` tree and modernize it. - Mark package as a module for zf-component-installer.
- Updated `JsonModel` to pull entity instance from `ZF\Hal\Entity` via `getEntity()` getter (instead of property access; change occurred in zf-hal 1.4). - Updated setup in `RenameUploadFilterFactoryTest` to pass servicemanager and array of config to filter manager constructor directly.
- In most cases, removed the `FactoryInterface` implementation, as that's the simplest route. - In the case of the UploadFileValidator, the factory needs to accept options, which is different between v2 and v3; as such, it implements the legacy interface to allow usage in both versions.
- Updated `RenameUploadFilterFactory` to work with both v2 and v3. - Fixed issue with return value in `UploadFileValidatorFactory`. - Updated `ContentTypeFilterListenerTest`, `ContentTypeListenerTest`, and `AcceptListenerTest` to vary how route matches are created, based on zend-mvc version detected.
- Added CONDUCT - Updated CONTRIBUTING to follow addition of scripts to `composer.json` and addition of CONDUCT. - Changed LICENSE to markdown. - Updated configuration to remove invokables. - PHPUnit configuration as dist file. - Instructions regarding zend-component-installer in README, and updates based on changes to module.
weierophinney
added a commit
that referenced
this pull request
Jul 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch completes the work begun in #71, with the following changes:
JsonModelto pull the composed user entity instance from aZF\Hal\Entityvia the newgetEntity()accessor added in the 1.4 release.Moduleclass into thesrc/directory, where it belongs.