8000 Consolidate device diagnostics and create a tool to regenerate them by puddly · Pull Request #284 · zigpy/zha · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Consolidate device diagnostics and create a tool to regenerate them #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Apr 24, 2025
Merged

Consolidate device diagnostics and create a tool to regenerate them #284

merged 28 commits into from
Apr 24, 2025

Conversation

puddly
Copy link
Contributor
@puddly puddly commented Oct 31, 2024

Combines the logic from HA Core, this library, and https://github.com/dmulcahey/zha-device-exporter/ into a single method: Device.get_diagnostics_json().

@puddly puddly force-pushed the puddly/combined-diagnostics branch from 9e2c905 to 664951c Compare October 31, 2024 20:45
@puddly
Copy link
Contributor Author
puddly commented Oct 31, 2024 •
edited
Loading

Everything works but with a small problem: clusters that modify the state (e.g. double battery percentage) modify it globally, so running the tool keeps doubling them after re-load. We'll need to restore entity state after loading device info, it seems.

Fixed with 9f4fe5b.

@codecov Codecov
Copy link
codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (1b6b5df) to head (427df30).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #284      +/-   ##
==========================================
+ Coverage   96.65%   96.67%   +0.02%     
==========================================
  Files          61       61              
  Lines        9922     9987      +65     
==========================================
+ Hits         9590     9655      +65     
  Misses        332      332

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dmulcahey
dmulcahey reviewed Nov 1, 2024
View reviewed changes
dmulcahey
dmulcahey reviewed Nov 1, 2024
View reviewed changes
dmulcahey
dmulcahey reviewed Nov 1, 2024
View reviewed changes
dmulcahey
dmulcahey reviewed Nov 1, 2024
View reviewed changes
@TheJulianJES TheJulianJES added the enhancement New feature or request label Nov 25, 2024
@puddly puddly force-pushed the puddly/combined-diagnostics branch from 97bebb3 to daf1a76 Compare April 15, 2025 18:13
@puddly
Copy link
Contributor Author
puddly commented Apr 15, 2025

I've rebased this PR. I think after the new unique_id migrations and entity lifecycle cleanup, we should be able to merge this.

@puddly puddly mentioned this pull request Apr 22, 2025
Merged
puddly added 19 commits April 24, 2025 13:17
@puddly
Consolidate ZHA device diagnostics
63978cd
@puddly
Create a tool to regenerate device diagnostics JSON
6786367
@puddly
Adjust endpoint device_type info to match earlier format
262b0ab
@puddly
Load last_seen
50d9a39
@puddly
Load topology information
0c89287
@puddly
Load LQI and RSSI
1e4019b 
Revert unnecessary change
@puddly
Reformat attribute serialization
7fec64e 
Dump the node descriptor

Ensure the output is stable

Ensure the output is stable
@puddly
Adjust to load new format
e40974b
@puddly
Prevent attribute updates during discovery tests
57d28e0
@puddly
Wait for background tasks when converting
e213515
@puddly
Update README
f27f677
@puddly
Mock regenerate diagnostics JSON during unit tests
4c38483
@puddly
Clean up a little
2ee2985
@puddly
Reorder JSON and move topology to the end
1639e57
@puddly
Compare the JSON directly within discovery tests
5492606
@puddly
Break test gateway out into a self-contained class
2c86ae1
@puddly
Break out a few more fixtures to eliminate pytest hacks
748fc3a
@puddly
WIP: create a tool to migrate legacy diagnostics
aae3558
@puddly
Fix up after rebase
1383395
@puddly puddly force-pushed the puddly/combined-diagnostics branch from daf1a76 to 1469613 Compare April 24, 2025 17:20
@puddly puddly marked this pull request as ready for review April 24, 2025 17:21
@puddly puddly force-pushed the puddly/combined-diagnostics branch from 1469613 to a343304 Compare April 24, 2025 17:23
@puddly puddly force-pushed the puddly/combined-diagnostics branch from a343304 to 28c88c8 Compare April 24, 2025 17:34
@puddly puddly merged commit b1d5b8f into zigpy:dev Apr 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmulcahey dmulcahey dmulcahey left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puddly @dmulcahey @TheJulianJES
0