8000 Remove `EntityType` from quirks v2 entity metadata handling by puddly · Pull Request #443 · zigpy/zha · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove EntityType from quirks v2 entity metadata handling #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2025
Merged

Remove EntityType from quirks v2 entity metadata handling #443

merged 2 commits into from
May 25, 2025

Conversation

puddly
Copy link
Contributor
@puddly puddly commented May 2, 2025

I don't see any regressions with existing devices so I think this change is good to go. We had only a few entity types without all three EntityType mappings already in place.

@codecov Codecov
Copy link
codecov bot commented May 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (758d8b1) to head (35ebd0e).
Report is 8 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #443   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          63       63           
  Lines       10362    10362           
=======================================
  Hits        10043    10043           
  Misses        319      319

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly marked this pull request as ready for review May 6, 2025 18:30
TheJulianJES
TheJulianJES approved these changes May 6, 2025
View reviewed changes
@puddly puddly added this to ZHA May 7, 2025
@puddly puddly moved this to In progress in ZHA May 7, 2025
@puddly puddly merged commit a2de928 into zigpy:dev May 25, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in ZHA May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJulianJES TheJulianJES TheJulianJES approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ZHA
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puddly @TheJulianJES
0