8000 Provide Windows error message by Froxcey · Pull Request #75 · zigzap/zap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Provide Windows error message #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2024
Merged

Provide Windows error message #75

merged 2 commits into from
Feb 22, 2024

Conversation

Froxcey
Copy link
Contributor
@Froxcey Froxcey commented Jan 31, 2024 •
edited
Loading

Yes, it is already in README. I just thought it would be nice if the build system explicitly fails Windows builds.

Test package available [here].

Just 2 LOC, thanks to Zig's beautiful build system.

Just wanna mention #74

vibe

renerocksai
renerocksai requested changes Feb 3, 2024
View reviewed changes
Copy link
Member
@renerocksai renerocksai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to merge this so you get the recognition.

AWESOME IDEA 👍 👍 👍 🥳

I really like it!

@Froxcey Froxcey requested a review from renerocksai February 12, 2024 08:36
@Froxcey
Copy link
Contributor Author
Froxcey commented Feb 12, 2024

Sorry, I was kind of on a vacation. Anyways, it should be good now

Example

@Froxcey
Copy link
Contributor Author
Froxcey commented Feb 12, 2024

Btw I saw your talk on Showtime, and I just want to say it's awesome :D

@Froxcey
Copy link
Contributor Author
Froxcey commented Feb 12, 2024 •
edited
Loading

Should @panic or std.log.err message be used?

The difference lies in that @panic gives a stack trace pointing to where @panic is invoked, whereas std.log.err + std.os.exit seems cleaner. Here are the screenshots:

@panic:
Version one

std.log.err + std.os.exit:
Version two

I personally prefer std.log.err + std.os.exit because the stack trace is not really adding any useful information to the already self-explanatory error message. I will convert this to a Draft PR temporarily to prevent an accidental merge.

@Froxcey Froxcey marked this pull request as draft February 12, 2024 16:28
@Froxcey Froxcey marked this pull request as ready for review February 19, 2024 12:38
@Froxcey
Copy link
Contributor Author
Froxcey commented Feb 19, 2024

I just committed the version with less chunky error message

renerocksai
renerocksai approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member
@renerocksai renerocksai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry so late but looks really good

@renerocksai renerocksai merged commit 92ad13d into zigzap:master Feb 22, 2024
@Froxcey Froxcey deleted the windows-errmsg branch February 25, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renerocksai renerocksai renerocksai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Froxcey @renerocksai
0