10000 Generalize returnValue access in @accessible macro by timaliberdov · Pull Request #4266 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Generalize returnValue access in @accessible macro #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2020
Merged

Generalize returnValue access in @accessible macro #4266

merged 1 commit into from
Oct 8, 2020

Conversation

timaliberdov
Copy link
Contributor

A tiny PR to use access* methods in all branches

@timaliberdov timaliberdov mentioned this pull request 8000 Oct 1, 2020
Merged
@adamgfraser
Copy link
Contributor

@timaliberdov Can you merge upstream changes?

@timaliberdov timaliberdov force-pushed the macros/generalize-return-value-access-in-accessible-macro branch from 9bd3dfa to d813d41 Compare October 8, 2020 18:10
@timaliberdov
Copy link
Contributor Author

@adamgfraser, rebased, but there is still a random-ish timeout in tests run:

image

@adamgfraser
Copy link
Contributor

@timaliberdov Thanks! Just restarted that one.

@adamgfraser adamgfraser merged commit 4cac39c into zio:master Oct 8, 2020
@timaliberdov timaliberdov deleted the macros/generalize-return-value-access-in-accessible-macro branch October 9, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgfraser adamgfraser adamgfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timaliberdov @adamgfraser
0