Remove Blocking From The Environment #5080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Reference user's lambda for the tracer | ||
| ZIOFn.recordTrace(() => effect) { | ||
| ZIO.effectSuspendTotal { | ||
| import java.util.concurrent.atomic.AtomicReference |
There was a problem hiding this comment.
|
|
||
| object Blocking { | ||
|
|
||
| val blockingExecutor: Executor = |
regiskuckaertz
approved these changes
May 15, 2021
jdegoes
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5076.
Removes the
Blockingservice from the environment. Blocking is now managed by a collection of operators that lock the effect to anExecutorbacked by a blocking thread pool. Right now this is just a global blocking thread pool but we could potentially allow each fiber to have a blocking executor as well as a normal executor associated with it. Then we could provide a variant ofshiftthat allowed setting that blocking executor to a new value. This would allow setting the blocking executor to a new value within a scope.