Deprecate ZIO#forkOn #5510
Merged
Deprecate ZIO#forkOn #5510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitlangton
approved these changes
Sep 2, 2021
|
Sounds great. I don't think this is common enough to necessitate a special pre-composed operator :) |
jdegoes
approved these changes
Sep 2, 2021
|
I agree with this. There's some code that can be removed in FiberContext too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we have been adding new operators over time this seems like one we can maybe cut out. It can already be implemented extremely compositionally as
zio.onExecutionContext(ec).forkwhich still provides a fluent API. There are a variety of ways one might want to customize a forked effect and I don't think this one is sufficiently common to warrant its own variant. It also seems odd that this takes anExecutionContextand not anExecutorwhenExecutoris supposed to be our first class representation of a thread pool.