Generalize Type Signature of ServiceWith #5558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
reviewed
Sep 8, 2021
| @@ -5427,7 +5427,7 @@ object ZIO extends ZIOCompanionPlatformSpecific { | |||
| } | |||
|
|
|||
| final class ServiceWithPartiallyApplied[Service](private val dummy: Boolean = true) extends AnyVal { | |||
| def apply[E, A](f: Service => ZIO[Has[Service], E, A])(implicit tag: Tag[Service]): ZIO[Has[Service], E, A] = | |||
| def apply[R <: Has[Service], E, A](f: Service => ZIO[R, E, A])(implicit tag: Tag[Service]): ZIO[R with Has[Service], E, A] = | |||
There was a problem hiding this comment.
Will this work:
Suggested change
| def apply[R <: Has[Service], E, A](f: Service => ZIO[R, E, A])(implicit tag: Tag[Service]): ZIO[R with Has[Service], E, A] = | |
| def apply[R, E, A](f: Service => ZIO[R, E, A])(implicit tag: Tag[Service]): ZIO[R, E, A] = |
There was a problem hiding this comment.
That was my original formulation. 😃
The issue there is that it leads to a lot of spurious warnings about R being inferred as Any.
There was a problem hiding this comment.
Or to be more precise there are a couple of permutations:
def apply[R, E, A](f: Service => ZIO[R, E, A])(implicit
tag: Tag[Service]
): ZIO[R with Has[Service], E, A] =This one leads to spurious warnings about a type being inferred as Any.
def apply[R <: Has[Service], E, A](f: Service => ZIO[R, E, A])(implicit
tag: Tag[Service]
): ZIO[R, E, A]This one leads to numerous warnings of missing parameter type for the effectual function.
jdegoes
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5555.