8000 Add failsWithA and diesWithA to test assertions by droptheplot · Pull Request #5838 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add failsWithA and diesWithA to test assertions #5838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 15, 2021

Conversation

droptheplot
Copy link
Contributor

@CLAassistant
Copy link
CLAassistant commented Oct 27, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor
@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps diesWithA and failsWithA?

@droptheplot
Copy link
Contributor Author

Perhaps diesWithA and failsWithA?

Right, or failsWith and diesWith would be enough?

Copy link
Contributor
@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick with the A syntax here since With normally indicates a variant that takes an additional function as a parameter.

adamgfraser
adamgfraser previously approved these changes Nov 5, 2021
@droptheplot droptheplot changed the title Add failsA and diesA to test assertions Add failsWithA and diesWithA to test assertions Nov 10, 2021
@adamgfraser adamgfraser merged commit 5d67dfa into zio:master Nov 15, 2021
jeroenr pushed a commit to jeroenr/zio that referenced this pull request Nov 25, 2021
* Add failsA and diesA to test assertions

* Rename to failsWith and diesWith

* Rename to failsWithA and diesWithA

* scalafmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0