Bring scalafix into root project/process #6045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0471006 to
ee71b41
Compare
ee71b41 to
abf26cd
Compare
swoogles
commented
Nov 16, 2021
| @@ -13,7 +13,7 @@ class CurriedAssert extends SemanticRule("CurriedAssert") { | |||
| override def fix(implicit doc: SemanticDocument): Patch = | |||
| doc.tree.collect { | |||
| case t @ assert(Term.Apply(name, List(value, assertion))) => | |||
| Patch.replaceTree(t, name + "(" + value + ")(" + assertion + ")") | |||
There was a problem hiding this comment.
This has been a warning for a long time, but now that it's part of the full build, we have to fix it to keep things passing.
adamgfraser
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to Scalafix running in the CI process, now we can edit files in the Scalafix project with navigation, integrated test running, etc. from the top-level ZIO project. Previously, you needed to open a separate editor in the
scalafixdirectory.