Fix scalafix after ZLayer->ZServiceBuilder PR #6041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swoogles
commented
Nov 15, 2021
| @@ -1638,19 +1638,19 @@ object ZIOSpec extends DefaultRunnableSpec { | |||
| } yield assert(res._1)(equalTo(List(0, 2, 4, 6, 8))) && assert(res._2)(equalTo(List(1, 3, 5, 7, 9))) | |||
| } | |||
| ), | |||
| suite("provideCustomServices")( | |||
There was a problem hiding this comment.
I think in the general case, it would be a mistake to try and "fix" user variable/test names/etc, so it's more accurate for our in Specs to have an old name and keep the old name in the output.
swoogles
commented
Nov 15, 2021
| testM("provides the part of the environment that is not part of the `ZEnv`") { | ||
| val loggingServiceBuilder: ZServiceBuilder[Any, Nothing, Logging] = Logging.live |
There was a problem hiding this comment.
Our input files should still have the old types, since they compile with the old version of ZIO
There was a problem hiding this comment.
I may have been a little aggressive in excising any references to ZLayer. 😅
swoogles
commented
Nov 15, 2021
| @@ -162,7 +162,11 @@ class Zio2Upgrade extends SemanticRule("Zio2Upgrade") { | |||
|
|
|||
| val ZIORenames = Renames( | |||
| List("zio.ZIO"), | |||
| Map("run" -> "exit") | |||
There was a problem hiding this comment.
This class has the only new migration logic added under this PR
ba8a2dc to
131d3a7
Compare
adamgfraser
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrections to some errant refactoring for
ZServiceBuilder.Also added some migrations around this type.
Created a ticket here to prevent this in the future:
#6040