Integrated fiber dumps #6152
Merged
Integrated fiber dumps #6152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoo
reviewed
Dec 13, 2021
| @@ -362,6 +363,8 @@ trait Runtime[+R] { | |||
| private final def unsafeRunWith[E, A]( | |||
| zio: ZIO[R, E, A] | |||
| )(k: Exit[E, A] => Any)(implicit trace: ZTraceElement): FiberId => (Exit[E, A] => Any) => Unit = { | |||
| val enableRoots = runtimeConfig.flags.isEnabled(RuntimeConfigFlag.EnableFiberRoots) | |||
There was a problem hiding this comment.
This is not used for anything
vigoo
previously approved these changes
Dec 13, 2021
d0b2099 to
fb3cd00
Compare
vigoo
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fiber dumps have been integrated into Core. As part of these changes:
Fiber#childrennow returns the children of the specified fiber, using the newevalOnmachinery to safely copy the contents of the weak set backing the children fibersFiber.rootsnow returns the root fibers, which are those created implicitly fromRuntime#unsafeRun*family of methodsRuntimeConfigFlag.EnableFiberRootscan now be used to turn on or off root fiber tracking. If off, then fiber dumps won't workFiber.dump*family of methods has been pruned and cleaned up; now only two methods exist,Fiber.dumpAllWith, andFiber.dumpAll.Fiber.Dump) are no longer optional; they always appearWeakConcurrentBaghas been introduced to aid tracking root fibers. This achieves zero allocations in the happy path and allows (weakly consistent) concurrent iteration