8000 Add ZChannel convertors to ZPipeline, ZSink and ZStream by sideeffffect · Pull Request #6213 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ZChannel convertors to ZPipeline, ZSink and ZStream #6213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 29, 2021
Merged

Add ZChannel convertors to ZPipeline, ZSink and ZStream #6213

merged 3 commits into from
Dec 29, 2021

Conversation

sideeffffect
Copy link
Member

No description provided.

@sideeffffect sideeffffect requested a review from iravid as a code owner December 26, 2021 03:53
sideeffffect
sideeffffect commented Dec 26, 2021
View reviewed changes
sideeffffect
sideeffffect commented Dec 26, 2021
View reviewed changes
adamgfraser
adamgfraser reviewed Dec 26, 2021
View reviewed changes
adamgfraser
adamgfraser reviewed Dec 26, 2021
View reviewed changes
Copy link
Contributor
@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how much benefit there is to having these operators versus just doing new ZStream(channel). There is potentially a lack of clarity that we're not really turning a channel into a stream, a stream is a channel. There is also some potential for confusion with other to methods that generally send the outputs of a channel somewhere else, versus this is just wrapping the channel in a more specialized type.

@sideeffffect
Copy link
Member Author
sideeffffect commented Dec 26, 2021 •
edited
Loading

I renamed the methods to asSink, asPipeline, asStream, I hope their purpose is clearer now

@adamgfraser
Copy link
Contributor

Let's stick with to and we can revisit the other operator names if needed.

@sideeffffect
Copy link
Member Author

OK, renamed 👍

@adamgfraser adamgfraser merged commit bdf3a5c into zio:series/2.x Dec 29, 2021
@kluen kluen mentioned this pull request Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgfraser adamgfraser adamgfraser approved these changes

@iravid iravid Awaiting request 4DB4 ed review from iravid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sideeffffect @adamgfraser
0