10000 Update docs about zio-aws by vigoo · Pull Request #6233 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update docs about zio-aws #6233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 1, 2022
Merged

Conversation

vigoo
Copy link
Contributor
@vigoo vigoo commented Jan 1, 2022

Updates the link and the example to the ZIO 2 version of zio-aws. My intention is to keep the old link and example for the ZIO 1.x documentation. I was not sure how the dual 1.x/2.x website is built so if this is not the way let me know ;)

I also removed the zio-aws dependencies from the docs project because the rest of the deps are not yet updated to ZIO 2 versions and it would make versions collide. I think the example was not in an mdoc block anyway.

@vigoo vigoo requested a review from khajavi January 1, 2022 09:21
@khajavi
Copy link
Member
khajavi commented Jan 1, 2022

@vigoo
Temporarily, we exclude all snippets from the mdoc compilation in the series/2.x branch, so it does not matter at this time. Finally, we should update all examples and include them in the mdoc block.

khajavi
khajavi previously approved these changes Jan 1, 2022
@adamgfraser adamgfraser merged commit 99589a2 into zio:series/2.x Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0