8000 Keep interrupting until it's done by regiskuckaertz · Pull Request #627 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Keep interrupting until it's done #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 16, 2019
Merged

Keep interrupting until it's done #627

merged 9 commits into from
Mar 16, 2019

Conversation

regiskuckaertz
Copy link
Member
@regiskuckaertz regiskuckaertz commented Mar 13, 2019 •
edited
Loading

Addresses

Note that the current method of sending a single interrupt to the thread may not work. We may have to put that in a while loop and try a few times.

@regiskuckaertz regiskuckaertz requested a review from jdegoes March 13, 2019 11:36
iravid
iravid reviewed Mar 13, 2019
View reviewed changes
jdegoes
jdegoes reviewed Mar 13, 2019
View reviewed changes
jdegoes
jdegoes reviewed Mar 13, 2019
View reviewed changes
iravid
iravid reviewed Mar 14, 2019
View reviewed changes
core/jvm/src/main/scala/scalaz/zio/blocking/Blocking.scala Outdated

if (looping) {
n += 1
Thread.sleep(base * n)
Copy link
Member 8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last note: probably good to bound this at something like 50ms. We don't want threads that fail to interrupt to cause this fiber to lock up a thread for long periods.

@regiskuckaertz regiskuckaertz merged commit bc0e44a into zio:master Mar 16, 2019
@regiskuckaertz regiskuckaertz deleted the rk-while-interrupt branch March 16, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes left review comments

@iravid iravid iravid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@regiskuckaertz @jdegoes @iravid
0