8000 Add TestSystem to testkit by pgabara · Pull Request #632 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add TestSystem to testkit #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2019
Merged

Add TestSystem to testkit #632

merged 1 commit into from
Mar 16, 2019

Conversation

pgabara
Copy link
Contributor
@pgabara pgabara commented Mar 14, 2019

fixes #622

jdegoes
jdegoes reviewed Mar 15, 2019
View reviewed changes
testkit/jvm/src/main/scala/scalaz/zio/testkit/TestSystem.scala Outdated
case class Data(
properties: Map[String, String] = Map.empty,
envs: Map[String, String] = Map.empty,
lineSeparator: String = ";"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should default to "\n"

jdegoes
jdegoes requested changes Mar 15, 2019
View reviewed changes
Copy link
Member
@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly perfect! Just a small tweak on a default and we need to make sure the Travis build passes. Otherwise, good to go!

@pgabara
Copy link
Contributor Author
pgabara commented Mar 16, 2019

Thanks @jdegoes. I updated pull request. Travis build passed too.

jdegoes
jdegoes approved these changes Mar 16, 2019
View reviewed changes
Copy link
Member
@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request! Looks great!

@jdegoes
Copy link
Member
jdegoes commented Mar 16, 2019

giphy

@jdegoes
Copy link
Member
jdegoes commented Mar 16, 2019

@bhop Congratulations on being a ZIO contributor! Please stick around. 😄

@jdegoes jdegoes merged commit 0c0b6a3 into zio:master Mar 16, 2019
@pgabara
Copy link
Contributor Author
pgabara commented Mar 17, 2019

@jdegoes Thanks!

@pgabara pgabara deleted the test_system branch March 17, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TestSystem to testkit package
2 participants
@pgabara @jdegoes
0