8000 Several minor documentation fixes by zawlazaw · Pull Request #6437 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Several minor documentation fixes #6437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

zawlazaw
Copy link
Contributor

This PR fixes several minor issues in the documentation of ZIO v2.x. In order to avoid too big PRs and to get some early feedback on my very first ZIO contribution, I focused so far only on the Sections Data Types / {Overview, Core Data Types, Contextual Types}. After this PR is merged, I would continue with the next sections in a similar way.

  • fixed several tiny typos, errors and formatting issues
  • unified the usage of **Note** instead of variants such as _**Note**_
  • removed a dedicated Java 8 fragment from a code example
  • changed mdoc:fail codeblocks into mdoc:fail:silent to suppress the auto-generated output which contained a lot of unrelated messages, and added only the intended error output manually as comments instead
  • propose alternative formulations for some sentences that sounded wrong or clumsy to me (please review these changes carefully, since I am not a native speaker)

I tried to exclude any refactorings that could trigger an opinionated discussion (e.g. whether we may also denote URIO an unexeptional effect), and collect such semantical discussions for future work.

@CLAassistant
Copy link
CLAassistant commented Mar 16, 2022

CLA assistant check
All committers have signed the CLA.

@adamgfraser
Copy link
Contributor

@zawlazaw Thanks for submitting! Will review this tomorrow!

Copy link
Contributor
@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@adamgfraser adamgfraser merged commit 9a56032 into zio:series/2.x Mar 17, 2022
@khajavi
Copy link
Member
khajavi commented Mar 17, 2022

@zawlazaw
A huge improvement on documentation.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0