Compositional Fiber Ref Updates #6485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
reviewed
Mar 27, 2022
jdegoes
reviewed
Mar 27, 2022
jdegoes
reviewed
Mar 27, 2022
jdegoes
reviewed
Mar 27, 2022
jdegoes
reviewed
Mar 27, 2022
jdegoes
reviewed
Mar 27, 2022
jdegoes
reviewed
Mar 27, 2022
| val (missingServices, patch) = sorted.foldLeft[(Map[LightTypeTag, Any], Patch[In, Out])]( | ||
| oldValue.map -> Patch.Empty().asInstanceOf[Patch[In, Out]] | ||
| ) { case ((map, patch), (tag, (newService, _))) => | ||
| map.get(tag) match { |
There was a problem hiding this comment.
If possible, we should have a couple tests to ensure that patching ZEnvironment is well-defined.
jdegoes
reviewed
Mar 27, 2022
jdegoes
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows defining a
FiberRefbased on a patch type that describes updates to theFiberRefas a data structure. This allows composing updates by multiple fibers to more complex values such as theZEnvironmentwithout "clobbering". The existingFiberRefsemantics are implemented as a specialized case where the patch is just a setter function.