8000 Added support for 'min' and 'max' on both Histogram and Summary. by scottweaver · Pull Request #6510 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added support for 'min' and 'max' on both Histogram and Summary. #6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 1, 2022
Merged

Added support for 'min' and 'max' on both Histogram and Summary. #6510

merged 11 commits into from
Apr 1, 2022

Conversation

scottweaver
Copy link
Contributor

No description provided.

@CLAassistant
Copy link
CLAassistant commented Mar 31, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@scottweaver scottweaver force-pushed the metrics/min+max_state branch from 8b4b72d to c05dff0 Compare April 1, 2022 01:29
jdegoes
jdegoes requested changes Apr 1, 2022
View reviewed changes
Copy link
Member
@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, and perfect time to get this in! A few comments on improving performance, and it looks like one legit flaky test that needs fixing. But otherwise looks great!

@adamgfraser adamgfraser merged commit 263a870 into zio:series/2.x Apr 1, 2022
@kluen kluen mentioned this pull request Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes requested changes

@adamgfraser adamgfraser adamgfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottweaver @CLAassistant @jdegoes @adamgfraser
0