10000 Optimize ZStream#groupByKey by adamgfraser · Pull Request #6630 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Optimize ZStream#groupByKey #6630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2022
Merged

Optimize ZStream#groupByKey #6630

merged 2 commits into from
Apr 16, 2022

Conversation

adamgfraser
Copy link
Contributor

Resolves #4191.

This is two orders of magnitude faster with the default chunk size.

Before:

[info] Benchmark                       (chunkCount)  (chunkSize)  (parChunkSize)   Mode  Cnt  Score   Error  Units
[info] StreamBenchmarks.zioGroupByKey           100         4096              50  thrpt   25  1.902 ± 0.093  ops/s

After:

[info] Benchmark                       (chunkCount)  (chunkSize)  (parChunkSize)   Mode  Cnt    Score   Error  Units
[info] StreamBenchmarks.zioGroupByKey           100         4096              50  thrpt   25  210.437 ± 5.933  ops/s

@adamgfraser adamgfraser requested a review from iravid as a code owner April 16, 2022 06:10
@adamgfraser adamgfraser requested review from vigoo and jdegoes April 16, 2022 07:21
@vigoo vigoo merged commit 5e712c3 into zio:series/2.x Apr 16, 2022
@adamgfraser adamgfraser deleted the 4191 branch April 16, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigoo vigoo vigoo approved these changes

@iravid iravid Awaiting requested review from iravid

@jdegoes jdegoes Awaiting requested review from jdegoes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamgfraser @vigoo
0