8000 Fix Chunk Packed Boolean Hash Code by adamgfraser · Pull Request #7109 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Chunk Packed Boolean Hash Code #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

Fix Chunk Packed Boolean Hash Code #7109

merged 1 commit into from
Jul 21, 2022

Conversation

adamgfraser
Copy link
Contributor

Resolves #7108.

@adamgfraser adamgfraser requested a review from jdegoes July 20, 2022 23:41
@987Nabil
Copy link
Contributor

@adamgfraser Hmm seems I missed that 😕
Somehow, it is unconvinient that it gives you no compile error. But most of the cases just get the class tag from the instance of Chunk. Would it make sense to put def classTag:ClassTag[A] in Chunk to have a compile error if it is missing?

@jdegoes jdegoes merged commit 912c0d6 into zio:series/2.x Jul 21, 2022
@adamgfraser adamgfraser deleted the 7108 branch July 21, 2022 13:00
@adamgfraser
Copy link
Contributor Author

@987Nabil I don't think that would necessarily solve it because we still need to use it in the implementation of classTagOf. Unfortunately it doesn't look like that triggers a pattern match exhaustivity warning. I think the more straightforward way to make sure this doesn't happen in the future is to have some tests that deconstruct the chunk in addition to construct it. That's why this didn't show up before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChunkPackedBoolean hashCode is broken
3 participants
@adamgfraser @987Nabil @jdegoes
0