8000 Zio 746 zip and zipPar consistency across all data types by jadireddi · Pull Request #748 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Zio 746 zip and zipPar consistency across all data types #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 15, 2019
Merged

Zio 746 zip and zipPar consistency across all data types #748

merged 5 commits into from
Apr 15, 2019

Conversation

jadireddi
Copy link
Contributor

@jadireddi
Copy link
Contributor Author

@jdegoes , Can you please review PR and let me know if any changes needed.

ghostdogpr
ghostdogpr reviewed Apr 14, 2019
View reviewed changes
core/shared/src/main/scala/scalaz/zio/Exit.scala Outdated
final def zip[E1 >: E, B](that: Exit[E1, B]): Exit[E1, (A, B)] = self <*> that

/**
* Zips the this result.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment needs to be fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

core/shared/src/main/scala/scalaz/zio/Exit.scala Outdated
final def zipLeft[E1 >: E, B](that: Exit[E1, B]): Exit[E1, A] = self <* that

/**
* Zips the specified result.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

core/shared/src/main/scala/scalaz/zio/Exit.scala Outdated
final def zipPar[E1 >: E, B](that: Exit[E1, B]): Exit[E1, (A, B)] = self <&> that

/**
* Zips the this result, in parallel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the 2 here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

jdegoes
jdegoes reviewed Apr 15, 2019
View reviewed changes
core/shared/src/main/scala/scalaz/zio/ZIO.scala
self &&& that

/**
* A named alias for `&&&` or `<*>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete &&& now that we have <*>. I know Haskell uses &&& but no reason for two symbols for the same operator.

@jdegoes
Copy link
Member
jdegoes commented Apr 15, 2019

@jadireddi Thank you for your work on this!

@jdegoes jdegoes merged commit 4fe18d5 into zio:master Apr 15, 2019
@jadireddi jadireddi deleted the ZIO_746-zip_consistency_across_all_data_types branch April 15, 2019 18:19
Dan-M added a commit to Dan-M/scalaz-zio that referenced this pull request Apr 16, 2019
@Dan-M
Merge branch 'upstream/master'
841458f 
* upstream/master:
  Update sbt-jmh to 0.3.6 (zio#762)
  Update silencer-lib, silencer-plugin to 1.3.3 (zio#752)
  Update sbt-scalajs, scalajs-compiler to 0.6.27 (zio#755)
  Zio 746 zip and zipPar consistency across all data types (zio#748)
  Interruptible monadic regions (zio#740)

# Conflicts:
#	build.sbt
ghostdogpr pushed a commit to ghostdogpr/scalaz-zio that referenced this pull request May 5, 2019
@jadireddi @ghostdogpr
Zio 746 zip and zipPar consistency across all data types (zio#748)
8a1bd4a 
* code changes for zip operator consistency between named and symbolic.

* code formatted

* code changes for zip and zipPar consistency.

* fixed typo's

* fixed the comments review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdegoes jdegoes jdegoes approved these changes

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jadireddi @jdegoes @ghostdogpr
0