Handle empty list keeping backward compatibility #7891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afsalthaj
commented
Mar 5, 2023
| loop(prefix, config, split = true).map(Chunk(_)) | ||
|
|
||
| case Right(chunk) => | ||
| if (chunk.size == 1 && (chunk.headOption.contains("<nil>"))) |
There was a problem hiding this comment.
<nil> is another way (along with empty string) to encode empty list when the config is actually indexed. Usually only libraries like zio-config (or advanced users) would ever need to encode emptiness using as a String<nil>
Users who prefer to write flat-structure hardly end up doing this and can use "" as before. This implies, as test cases indicate, we keep all the existing behaviour of ConfigProvider as it is.
We can remove this pre-requisite in zio-3.x, where ConfigPath is the default behaviour
afsalthaj
commented
Mar 5, 2023
| if (chunk.size == 1 && (chunk.headOption.contains("<nil>"))) | ||
| ZIO.succeed(Chunk.empty).map(Chunk(_)) | ||
| else loop(prefix, config, split = true).map(Chunk(_)) | ||
|
|
There was a problem hiding this comment.
FIXME: A bit of clean up - just tested the functionality as of now and it works
adamgfraser
approved these changes
Mar 5, 2023
This was referenced Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<nil>is another way (along with empty string) to encode empty list when the config is actually indexed. Usually only libraries like zio-config (or advanced users) would ever need to encode emptiness using as a String<nil>Users who prefer to write flat-structure hardly end up doing this and can use "" as before. This implies, as test cases indicate, we keep all the existing behaviour of ConfigProvider as it is.
We can remove this pre-requisite in zio-3.x, where ConfigPath is the default behaviour