Don't use Java reflection for ScalaJS / Native #8841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR (#8614) broke
zio-test_2.12for ScalaJS & Native due to usage of Java reflection.This PR implements a platform-specific
productFieldsmethod, where in ScalaJS and Scala Native it returns an iterator of empty strings.This is OK because the next line in the code handles empty strings explicitely:
zio/test/shared/src/main/scala-2.12/zio/test/AssertionVariants.scala
Line 58 in 7300705
See Discord chat for more info: https://discord.com/channels/629491597070827530/629491597070827534/1238126111490048094