Use an improved eq in FiberRefs and add shortcut for join
#9100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
approved these changes
Aug 12, 2024
| * method shows up in benchmarks, make sure to compile the code with the | ||
| * envvar set. | ||
| */ | ||
| private def improvedEq[A <: AnyRef](x: A, y: A): Boolean = { |
There was a problem hiding this comment.
It's not great, but: eqWithBoxedNumericEquality?
ghostdogpr
previously approved these changes
Aug 13, 2024
|
My apologies @ghostdogpr, I ended up making some final adjustments after your review:
|
ghostdogpr
approved these changes
Aug 13, 2024
jdegoes
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things I didn't account for in #8989 is that
eqon boxed primitives returns false even if the underlying integer is the same 🫠. The fix is rather simple; typecheck the value and if it's ajava.lang.Numberthen unbox it and compare it (viaBoxesRunTime.equalsNumObject.While I was doing this, I thought to also do the following:
improvedEqproduces the same outcome as==(note that this assertion does not exist in the published artifacts!).FiberRefswhich are equal according toeq. This is a very common case especially when we doZIO.foreachPar, since in most cases we won't be modifying any of the FiberRefs in any of the effects run in parallel. Therefore,inheritAllthen becomes much cheaper, which overall improves the performance offoreachParquite substantially:series/2.x
PR
Note that in some rare cases, the
ZEnvironment.Patch.diffwill return a Patch that when applied, it will result having the same services in the environment. To avoid this, I added a guard against this by checking that the resulting ZEnvironment is indeed different (as determined by==). I think that since our equals method onZEnvironmentis fairly well optimized, I'm thinking it's better not to risk destroying theFiberRefsoptimizations and perform this check. Thoughts?