Revert "makeSome refactoring" #9151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c16f288.
hearnadam
approved these changes
Aug 28, 2024
jdegoes
approved these changes
Aug 28, 2024
|
@kyri-petrou I agree. I am unable to reproduce the same issues. I also don't know why they don't trigger here, as there are tests that seem to cover all the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9077
/fixes #9145
@pablf @jdegoes @ghostdogpr given how widespread #9145 is, and since #9147 doesn't seem to solve it (plus it introduces some other regressions), I think the best course of action is to revert the changes and release a patch version.
@pablf Before we proceed with #9077 again and any fix to it, we need to isolate the issue / create a reproducer for it to avoid it happening again.