Fix ZPool finalizers not running when resource acquisition fails or is interrupted #9163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
commented
Sep 3, 2024
| for { | ||
| latch <- Promise.make[Nothing, Unit] | ||
| latch2 <- Promise.make[Nothing, Unit] | ||
| incCounter = ZIO.acquireRelease(ZIO.unit)(_ => latch2.succeed(())) |
There was a problem hiding this comment.
Note: We can't use a counter in this test because the interruption is "disconnected", so we need to use a promise and await it to check whether it's been completed
jdegoes
approved these changes
Sep 3, 2024
|
@jdegoes PS: I noticed some test flakiness; I looked into it and it doesn't seem to be related to the changes to the library code but to the addition of the |
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #9152
/claim #9152
The previous behaviour would run the finalizers within an interruptible region in case of a failure. This means that in cases where the acquisition would be interrupted after some resource was first initialized (either due to interruption or failure) the finalizers wouldn't be run and the pool would contain invalid items.
/cc @987Nabil this should fix the flaky test in ZIO HTTP, but I'll test it more extensively once there's a snapshot version out