8000 Ensure that transactions containing both reads and writes are consistent by kyri-petrou · Pull Request #9265 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ensure that transactions containing both reads and writes are consistent #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

Ensure that transactions containing both reads and writes are consistent #9265

merged 2 commits into from
Oct 30, 2024

Conversation

kyri-petrou
Copy link
Contributor

/fixes #9264

Issue seems to be in a bug where the commit logic was inconsistent between the two branches in the retry loop (retries >= MaxRetries). Fixed it by extracting the logic into a common method for determining whether we commit and/or continue looping

@kyri-petrou kyri-petrou marked this pull request as ready for review October 30, 2024 05:47
@kyri-petrou kyri-petrou merged commit 54bbe97 into zio:series/2.x Oct 30, 2024
18 checks passed
@kyri-petrou kyri-petrou deleted the fix-zstm-read-write-consistency branch October 30, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZSTM doesn't guarantee consistency
2 participants
@kyri-petrou @ghostdogpr
0