8000 Optimize pattern-matching in `ZIO`/`Exit` methods by kyri-petrou · Pull Request #9415 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Optimize pattern-matching in ZIO/Exit methods #9415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2024
Merged

Optimize pattern-matching in ZIO/Exit methods #9415

merged 2 commits into from
Dec 16, 2024

Conversation

kyri-petrou
Copy link
Contributor
  • Avoid invocation of the unapply method. This results in a slightly more optimized bytecode as it requires 1 less local variable to be stored in the stack
  • Replace redundant type-checking in patmats when we can simply use case _ => ???

@kyri-petrou kyri-petrou requested a review from guizmaii December 15, 2024 04:03
guizmaii
guizmaii previously approved these changes Dec 15, 2024
View reviewed changes
regiskuckaertz
regiskuckaertz reviewed Dec 15, 2024
View reviewed changes
@kyri-petrou kyri-petrou merged commit 4d97950 into zio:series/2.x Dec 16, 2024
18 checks passed
@kyri-petrou kyri-petrou deleted the avoid-unapply-patmat-exit branch February 10, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regiskuckaertz regiskuckaertz regiskuckaertz approved these changes

@guizmaii guizmaii guizmaii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyri-petrou @regiskuckaertz @guizmaii
0