8000 More `Exit` optimizations for `ZIO` methods by kyri-petrou · Pull Request #9427 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

More Exit optimizations for ZIO methods #9427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2024
Merged

More Exit optimizations for ZIO methods #9427

merged 3 commits into from
Dec 17, 2024

Conversation

kyri-petrou
Copy link
Contributor

Main changes:

  • Replace few remaining usages of ZIO.succeed with Exit.succeed
  • Remove overriding of methods that already eagerly evaluate Exits. While this results in slightly more allocations, I think it's still better than overriding the methods as the JVM can better optimize/inline methods that are final / not overwritten by implementations

@kyri-petrou kyri-petrou requested a review from guizmaii December 17, 2024 07:28
@kyri-petrou kyri-petrou merged commit cf5d8ae into zio:series/2.x Dec 17, 2024
18 checks passed
@kyri-petrou kyri-petrou deleted the consolidate-zio-optimizations branch December 21, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regiskuckaertz regiskuckaertz regiskuckaertz approved these changes

@guizmaii guizmaii Awaiting requested review from guizmaii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyri-petrou @regiskuckaertz
0