8000 More efficient parsing of line numbers without string allocations by plokhotnyuk · Pull Request #9433 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

More efficient parsing of line numbers without string allocations #9433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 19, 2024
Merged

More efficient parsing of line numbers without string allocations #9433

merged 4 commits into from
Dec 19, 2024

Conversation

plokhotnyuk
Copy link
Contributor
@plokhotnyuk plokhotnyuk commented Dec 18, 2024 •
edited by guizmaii
Loading

@plokhotnyuk plokhotnyuk mentioned this pull request Dec 18, 2024
Closed
@guizmaii
Copy link
Member
guizmaii commented Dec 18, 2024 •
edited
Loading

@plokhotnyuk Could you add a test with Int.Max as the line number to parse, please?

Tests are here:

  • zio/internal/stacktracer/TracerSpec.scala
  • core-tests/shared/src/test/scala-3/zio/.internal/.stacktracer/TracerSpec.scala

kyri-petrou
kyri-petrou approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor
@kyri-petrou kyri-petrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🫶

@kyri-petrou kyri-petrou merged commit bc18e4a into zio:series/2.x Dec 19, 2024
18 checks passed
@guizmaii guizmaii mentioned this pull request Jan 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guizmaii guizmaii guizmaii left review comments

@kyri-petrou kyri-petrou kyri-petrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracer. instance does regex pattern match for filtered out logs
3 participants
@plokhotnyuk @guizmaii @kyri-petrou
0