Print interruptions in ZIO#debug
#9473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
previously approved these changes
Jan 22, 2025
Comment on lines
460
to
461
| case exit @ Exit.Success(value) => println(s"$prefix: $value"); exit | ||
| case exit @ Exit.Failure(error) => println(s"<FAIL> $prefix: $error"); exit |
There was a problem hiding this comment.
Side effecting code without explicit suspension always makes my eyes bleed...
There was a problem hiding this comment.
I wrapped the calls to println within ZIO.succeed. I also realised there was another debug method that had to be changed so I fixed that one as well
There was a problem hiding this comment.
Thanks. I don't think it's strictly necessary since exitWith will actually suspend, but I think it's probably for the best.
hearnadam
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ZIO#debugdoesn't print anything when the effect is interrupted, which can be annoying if using this method to debug issues