Optimize ZIO.fail
#9487
Merged
Optimize ZIO.fail
#9487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
approved these changes
Jan 22, 2025
| val builder = stackTraceBuilderPool.get() | ||
|
|
||
| val stack = _stack | ||
| val size = _stackSize // racy | ||
|
|
||
| builder += _lastTrace |
There was a problem hiding this comment.
Was this missing from the trace before? Do we have any tests for trace generation?
There was a problem hiding this comment.
It wasn't missing, but because earlier we were going deeper into the runloop stack this would be present in the stack itself. Now since the invocation is flat we have to add it.
Do we have any tests for trace generation
Yes a test failed after updating the code and the fix was to add this here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZIO.failis commonly used not only for raising errors, but also as shortcut (e.g.,ZIO.fail(None)). While we're trying to useExit.failas much as possible when we need to shortcut, there are still quite a lot of usages ofZIO.failboth within the coreziorepo and inzio-*libraries.This PR optimizes
ZIO.failso that we get all the info we need to build the failure with 2 iterations of the runloop instead of 4