Optimize FiberRef#locallyScopedWith
#9483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
8000
reviewed
Jan 20, 2025
| @@ -185,7 +185,7 @@ trait FiberRef[A] extends Serializable { self => | |||
| * value when the scope is closed. | |||
| */ | |||
| final def locallyScopedWith(f: A => A)(implicit trace: Trace): ZIO[Scope, Nothing, Unit] = | |||
| getWith(a => locallyScoped(f(a))(trace)) | |||
| ZIO.acquireRelease(get.flatMap(a => set(f(a)).as(a)))(set).unit | |||
There was a problem hiding this comment.
Can't we use getAndSet here?
There was a problem hiding this comment.
Hum no but we can use modify. I'll update the implementation
Removing one `get` call
e9710d6 to
fda2d2e
Compare
kyri-petrou
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing one
getcall