Make *VersionSpecific and *PlatformSpecific traits package-private
#9491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
approved these changes
Jan 23, 2025
| def unexpected: Nothing = sys.error("Unexpected invocation") | ||
|
|
||
| implicit def neq[A, B]: A =!= B = new =!=[A, B] {} | ||
| implicit def neq[A, B]: A =!= B = instance.asInstanceOf[=!=[A, B]] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a lot of
*VersionSpecificand*PlatformSpecifictraits that are public. This is unnecessary and likely also a bit distracting for users when they have imports such asimport zio.*.Other minor changes:
=!=(no idea why this wasn't sealed previously)lazy val EnvironmentTag = izumi.reflect.Tagto justvalNote that making traits / classes / methods package-private is binary compatible as in the compiled bytecode, package-private objects are public.