8000 Optimize `ZIO::flatMapError` encoding by guizmaii · Pull Request #9585 · zio/zio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Optimize ZIO::flatMapError encoding #9585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

Optimize ZIO::flatMapError encoding #9585

merged 1 commit into from
Feb 13, 2025

Conversation

guizmaii
Copy link
Member

No description provided.

@guizmaii guizmaii self-assigned this Feb 12, 2025
@hearnadam
Copy link
Collaborator

I noticed that flipWith is not correctly suspended. Since it accepts a user method, doesn't it require: suspendSucceed?

f(self.flip).flip

@guizmaii
Copy link
Member Author
guizmaii commented Feb 13, 2025 •
edited
Loading

@hearnadam your question is a bit out of the scope of this PR but it is good question.
I'd say no, as it's transforming something already suspended (an IO) 🤔

@hearnadam hearnadam merged commit 17d5d7f into series/ 7ECB 2.x Feb 13, 2025
18 checks passed
@hearnadam hearnadam deleted the flatMapError_encoding branch February 13, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hearnadam hearnadam hearnadam approved these changes

@kyri-petrou kyri-petrou kyri-petrou approved these changes

Assignees

@guizmaii guizmaii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guizmaii @hearnadam @kyri-petrou
0