Avoid excessive filesystem read/writes during test execution #9795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
reviewed
Apr 15, 2025
| @@ -7,66 +7,42 @@ import java.nio.file.Path | |||
|
|
|||
| object ResultFileOpsJsonSpec extends ZIOBaseSpec { | |||
| def spec = suite("ResultFileOpsJsonSpec")( | |||
| test("simple write")( | |||
| test("writes lines within the result array sequentially")( | |||
There was a problem hiding this comment.
The previous testing didn't have this, but given the special casing for commas, should we have that in the test?
Otherwise LGTM
There was a problem hiding this comment.
The previous testing didn't have this
I know but I wanted to have a more "deterministic" test that wrote things sequentially and a non-deterministic one that tested parallel writes
but given the special casing for commas, should we have that in the test
Good point, I'll add this
guizmaii
reviewed
Apr 15, 2025
| } | ||
| .ignore | ||
| ) | ||
| private[test] class Json private (resultPath: String) extends ResultFileOps { |
hearnadam
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #9783
Currently we're appending the result of each test to a file. When test execution finishes, we load up the entire file, and then write each line by opening / closing a new
java.io.FileWriter. This is very inefficient especially for large test suites.With this PR we store all the writes in a queue which we then drain and write its contents to the FS once we close
ResultFileOps.Previously, running
coreTestsJVM/testlocally required 10 seconds (!!!) for the test reports to be written to the file, whereas now it's done in a matter of milliseconds.