Enqueue+Dequeue: add shutdownCause method
#9928
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
commented
Jun 3, 2025
| val capacity: Int = | ||
| hub.capacity | ||
| def isShutdown(implicit trace: Trace): UIO[Boolean] = | ||
| ZIO.succeed(shutdownFlag.get) | ||
| def publish(a: A)(implicit trace: Trace): UIO[Boolean] = | ||
| ZIO.suspendSucceed { | ||
| if (shutdownFlag.get) ZIO.interrupt | ||
| if (shutdownFlag.get) interrupted |
There was a problem hiding this comment.
I think we could actually unify on the shutdownHook being the single atomic for this class. Checking promise.unsafe.isDone...
There was a problem hiding this comment.
Yeah I actually thought about doing that in the past as well. Not sure why I didn't do it 🤔
- implement method for `Hub` and `Queue`
kyri-petrou
reviewed
Jun 3, 2025
| @@ -161,14 +167,16 @@ object Queue extends QueuePlatformSpecific { | |||
| strategy: Strategy[A] | |||
| ) extends Queue[A] { | |||
|
|
|||
| private def interrupted(implicit trace: Trace): UIO[Nothing] = shutdownHook.await *> ZIO.interrupt | |||
There was a problem hiding this comment.
If shutdownHook was fulfilled with an interruption then we don't need the *> ZIO.interrupt (AFAICT)
There was a problem hiding this comment.
That won't typecheck, but yes
mberndt123
reviewed
Jun 8, 2025
| * Shuts down the Dequeue with a specific Cause, either `Die` or `Interrupt`. | ||
| * Future calls to `take*` fail immediately. | ||
| */ | ||
| def shutdownCause(cause: Cause[Nothing])(implicit trace: Trace): UIO[Unit] = shutdown(trace) |
There was a problem hiding this comment.
Note that the original ticket says:
shutdownCausewould also return the items currently buffered in the queue in order to dispose of them
Do you plan to implement that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #9844
HubandQueue