Experimental build.zig #262
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenzek
commented
Jun 13, 2025
| @@ -450,7 +427,9 @@ fn testSetIdx(val: usize) void { | |||
| } | |||
|
|
|||
| fn testFn() void { | |||
| std.debug.assert(remainingStackSize() > 2048); | |||
| // Check if the stack was already overflowed | |||
| const current = xframe(); | |||
There was a problem hiding this comment.
@Corendos not sure what this test is doing but it's not compiling anymore.
| @@ -18,10 +18,10 @@ pub const log = std.log.scoped(.@"zml/aio"); | |||
| test { | |||
| std.testing.refAllDecls(@This()); | |||
| std.testing.refAllDecls(gguf); | |||
| std.testing.refAllDecls(nemo); | |||
| // std.testing.refAllDecls(nemo); | |||
| std.testing.refAllDecls(safetensors); | |||
There was a problem hiding this comment.
I haven't ported the yaml deps to build.zig, but also not sure it's worth it. The nemo/yaml code doesn't compile anyway.
| @@ -25,7 +25,6 @@ zig_library( | |||
| visibility = ["//visibility:public"], | |||
| deps = [ | |||
| ":posix", | |||
| ":sentencepiece_model_proto", | |||
| @@ -35,9 +34,7 @@ zig_library( | |||
| "//stdx", | |||
| "//zml/tokenizer", | |||
| "//zml/tools", | |||
| "@rules_zig//zig/lib:libc", | |||
9c591b3 to
d09a6a5
Compare
fixup! add "zml_sandbox"
57364d0 to
7be70e8
Compare
7be70e8 to
dfd92dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! This build.zig is experimental !!!
#67
It shows how to bridge Bazel and build.zig.
It requires the user to have
bazelandtarinstalled on their machine.Bazel is used to:
build.zig finishes the work by:
zig build test --summary allwill run a lot of testszig build test-zmlwill stick to ZML test suitezig build -Druntimes:cpu=true -Druntimes:cuda=false testwill enable/disable runtimesCaveats:
ziglang/zig@8eb5813
this works around zig fetch: Erroneous
FileBusyerror if package tarball's paths are prefixed with./ziglang/zig#23152Potential follow ups:
The main missing is that Bazel takes care of sandboxing
ZML executables and the PJRT runtimes and all the dependencies.
This part has not been added to build.zig beyond mininal rPath for the the libpjrt_xxx.so,
but for cuda you have more depedencies that would need to be sandboxed.
The module graph of the various protobuffers is alson a bit big,
and if it changes it will be tedious to update. Ideally bazel should generate this graph of deps for us.