Implemented channel sorting + stable join order #238
Conversation
|
Uhm, so this sorts zncs internal channel vector. So what? This won't work e.g. when you connect to znc before it joins channels and... dunno |
|
Yup, this works only when reconnecting to znc and this is exactly my use case (and to be honest the only usecase I can imagine for implementing this). When I connect to znc (with xchat or irssi) I want my channels to be in the correct order, which I specify by setting a sort order. Both irssi and xchat obey the order in which they get the join messages from znc and therefore on connect my channels are sorted. Also this works by configuring the SortOrder attribute in your znc.conf before starting znc (but that is not my usecase). I CAN reorder my channels in xchat but I cannot carry that state between restarts of xchat. Also there is no (easy) way to give xchat the ability to sort the channels like I want them. Another advantage of doing this in znc is that I have my ordering independant from the device which I use ot connect to znc. On the "won't work before znc joins the channels": That is correct. ZNC lets you join the channels in the order it is able to join the channels. One could do dirty things with timers against that but I don't consider that being useful. As I intend to keep my bouncer running this corner case shouldn't happen that often to me (and in that case I always could tell my IRC client to reconnect and everything is shiny). |
|
For irssi: /layout save and /save |
|
This would be superb useful IMO. |
|
Just reading though the code it looks simple enough and would be useful for me. |
|
This is not yet solved. Today i have lose the correct order with ZNC, and HexChat obey the order. After more restart is all the same with ZNC, is bad sorted. ZNC not look what is in normal IRC client order sometimes. |
|
It seems that there are commits here after the last comment (GitHub doesn't notify when commits are added to PR, you must comment after that so repo owners get hte information) and the PR has merge conflict. |
|
No new commits are added to it... They are cherry-picks of this commit to 2016-02-02 10:31 GMT+00:00 Mikaela Suomalainen notifications@github.com:
|
REDO znc/pull/238. thanks sebageek
|
Surprised this isn't merged yet. Sure, it's not perfect, but ZNC is basically unusable without it IMO... Rebased on 1.7.1 here: https://bpaste.net/show/8a0623b000ba |
When connecting to znc the join is unpredictable (or in the same way it was when znc was started the first time). With this patch a sort order can be defined. This is an numeric attribute attached to each channel. On AddChannel() SortChannels() is called. This also happens when setting a SortOrder via the *status bot thingy.
Fix #104