Apply macOS radio/checkbox normalization to import wizard #5039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And replace the left margin with `overflow: visible` so controls stay aligned.
tnajdek
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Thanks! I like the idea of a mixin for form/control normalization!
There are a couple of issues I've noticed after normalization. First, the controls are cramped vertically, is this intentional or can we add some padding between the lines? Second, the checkboxes now have mismatched sizes, probably due to some other hacky or legacy CSS that can now be removed—both issues are visible in the screenshot below.
It's probably easier for me to take care of these, just please let me know if we want to add any vertical padding.
From what I can see, the mismatched sizes are not due to a focus ring, but I haven't investigated the cause yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And replace the left margin with
overflow: visibleso controls stay aligned.